Skip to content

chore(gen): use svg badges in README.md #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2015
Merged

chore(gen): use svg badges in README.md #1251

merged 1 commit into from
Sep 6, 2015

Conversation

kingcody
Copy link
Member

@kingcody kingcody commented Sep 5, 2015

No description provided.

@kingcody
Copy link
Member Author

kingcody commented Sep 6, 2015

Should I add the dev-dependencies badge for the generator to this PR?

@kingcody
Copy link
Member Author

kingcody commented Sep 6, 2015

Added the dev-dependencies badge and moved the gitter badge to the next line. You can view the changes here.

@Awk34 Awk34 added the chore label Sep 6, 2015
@Awk34
Copy link
Member

Awk34 commented Sep 6, 2015

Might as well put all the badges on new lines; makes everything more readable.

@kingcody
Copy link
Member Author

kingcody commented Sep 6, 2015

Hmm, well it seems for markdown there has to be a blank line between images for them to not be inline, which adds a lot of whitespace: https://github.com/DaftMonk/generator-angular-fullstack/blob/f435c4fb5526a6fb2eeba379b511871f189e2f76/readme.md

@Awk34
Copy link
Member

Awk34 commented Sep 6, 2015

Yeah I just meant like this:

[![Build Status](https://travis-ci.org/DaftMonk/generator-angular-fullstack.svg?branch=master)](http://travis-ci.org/DaftMonk/generator-angular-fullstack)
[![npm version](https://badge.fury.io/js/generator-angular-fullstack.svg)](http://badge.fury.io/js/generator-angular-fullstack)
[![Dependency Status](https://david-dm.org/daftmonk/generator-angular-fullstack.svg)](https://david-dm.org/daftmonk/generator-angular-fullstack) [![Dev-Dependency Status](https://david-dm.org/daftmonk/generator-angular-fullstack/dev-status.svg)](https://david-dm.org/daftmonk/generator-angular-fullstack#info=devDependencies)
[![Gitter chat](https://badges.gitter.im/DaftMonk/generator-angular-fullstack.svg)](https://gitter.im/DaftMonk/generator-angular-fullstack)

@kingcody
Copy link
Member Author

kingcody commented Sep 6, 2015

Yeah, that makes sense.

@kingcody
Copy link
Member Author

kingcody commented Sep 6, 2015

https://github.com/DaftMonk/generator-angular-fullstack/blob/chore/svg-badges/readme.md

Awk34 added a commit that referenced this pull request Sep 6, 2015
@Awk34
Merge pull request #1251 from DaftMonk/chore/svg-badges
f0cff1b 
chore(gen): use svg badges in `README.md`
@Awk34 Awk34 merged commit f0cff1b into canary Sep 6, 2015
@kingcody kingcody deleted the chore/svg-badges branch September 9, 2015 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Awk34 Awk34

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingcody @Awk34